Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network improvements #59

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Network improvements #59

wants to merge 13 commits into from

Conversation

@2bndy5 2bndy5 added the enhancement New feature or request label Jun 8, 2024

This comment was marked as off-topic.

@2bndy5 2bndy5 force-pushed the network-improvements branch from 63cbb01 to 8818abc Compare June 8, 2024 15:28
@2bndy5
Copy link
Member Author

2bndy5 commented Jun 17, 2024

I think the bug fixed in nRF24/RF24Network#229 is specific to the C++ implementation. Looking at the _write_to_pipe(), I forgot how much code gulf I played to speed things up.

There is no RF24Network.networkFlags here because

  • message fragmentation is done directly in _write_to_pipe() (making FLAG_FAST_FRAG obsolete)
  • FLAG_NO_PULL is implemented as _parenthood, even though there is no RF24Gateway/Ethernet implementation in this CirPy port

Furthermore, the network layers here don''t use a writefast() equivalent. Instead, I use a regular blocking write() (RF24.send()) and call RF24Network._tx_standby() which uses RF24.resend() similarly to how C++ RF24::txStandBy() uses RF24::reUseTx() but in a blocking manner.

@2bndy5 2bndy5 force-pushed the network-improvements branch from 24449d8 to 07668d4 Compare June 20, 2024 21:08
@2bndy5 2bndy5 force-pushed the network-improvements branch from e7a2916 to 685ced7 Compare June 28, 2024 23:27
@2bndy5 2bndy5 force-pushed the network-improvements branch from 685ced7 to cb9b60b Compare June 29, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant